New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286177: C2: "failed: non-reduction loop contains reduction nodes" assert failure #1195
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8286177
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
71bc9cc
to
a276055
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like something went wrong. Original patch is much larger!
Hi Martin, |
Yes, at least the "Files changed" tab doesn't show enough. I suggest to remove the Commit and replace it by a new one. |
It shows two files. superword.cpp and the new test. What is missing? I don't see more files edited in the original change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see only two files. Lgtm.
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me, nothing missing.
Why does the 17u backport change 6 files openjdk/jdk17u-dev#495 while this one shows 2 files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it could be recognized as clean when using the hash from https://git.openjdk.java.net/jdk/commit/6458a56e60472fb2fbe8fa60bbc856dc95f50f07. The actual change LGTM, but the 17u question remains.
In the PR for 17 you see the files of the dependent pull request. It includes the predecessor change. Please look at the commit to 17u. |
Thanks for all the reviews! |
Going to push as commit a10ef71.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.17-oracle.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1195/head:pull/1195
$ git checkout pull/1195
Update a local copy of the PR:
$ git checkout pull/1195
$ git pull https://git.openjdk.org/jdk11u-dev pull/1195/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1195
View PR using the GUI difftool:
$ git pr show -t 1195
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1195.diff